1070860 - [Loop] Wrong message if user try to make a call and is not logged-in

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[mbarone]

Attachment: 2014-09-22-10-10-37.png

STR
1. Intall Loop App
2. From contact app, make a call to a valid Loop ID user

ACTUAL RESULT
The warning message is "You need to be logged in before making a call with Loop"

EXPECTED RESULT
Loop should be not present in the warning message

Comment 1

[Maria Angeles Oteo (:oteo)]

I suppose that we need to say "You need to be logged in before making a call with Firefox Hello"
Pau, Rafa, can you confirm it, please?

Comment 2

[Rafael Rebolleda]

A little tweak: "You need to be logged in to use Firefox Hello".

Nice-to-have:

Two buttons below => [Ok] [Log in]

Obviously the latter takes the user to the app.

Comment 3

[Pau Masiá [:Pau]]

Attachment: Prompt

It should be like this, then :)

Comment 4

[Maria Angeles Oteo (:oteo)]

Arnau, if including the screen with the two buttons is complex, let's fix the string issue only in this bug that's the important one.

Comment 5

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Just changed the locales in my patch, as the screen is an alert and not a confirm, the new implementation won't be quick, we should open a follow up to address that.

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 7

[Maria Angeles Oteo (:oteo)]

(In reply to Arnau March  [:arnau] from comment #5)
> Just changed the locales in my patch, as the screen is an alert and not a
> confirm, the new implementation won't be quick, we should open a follow up
> to address that.

Opened bug 1073498 for that enhancement

Comment 8

[Borja Salguero [:borjasalguero]]

Comment on attachment 8495900 [details] [review]
patch in github

Please rebase and merge it! Thanks!

Comment 9

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Merged: 4e1f2b4d7c6a5c418c5adc1f895bb681200a0422

Comment 10

[mbarone]

Tested with Gecko-675810c.Gaia-092d2b7 and Loop v. d159db7 and works fine